[MPlayer-DOCS] CVS: homepage/src projects.src.hu,1.62,1.63

[Diego Biurrun]

Guillaume POIRIER writes:
> Le vendredi 05 novembre 2004 à 11:37 +0100, Diego Biurrun a écrit :
> > 
> > I was thinking about the Debian section of the XML documentation, but
> > the README is also a good place.  Please commit with the suggested
> > changes.  Could you also update the XML docs afterwards?
> 
> Here's the patch you asked for. Even though it's very trivial, I'm not
> sure I followed the design rules of XML docs, so please review.
> 
> --- main_modif/DOCS/xml/en/ports.xml	2004-11-06 12:29:48.000000000 +0100
> +++ main/DOCS/xml/en/ports.xml	2004-11-07 21:12:03.000000000 +0100
> @@ -19,6 +19,15 @@
>  To build a Debian package, run the following command in the
>  <application>MPlayer</application> source directory:
>  <screen>fakeroot debian/rules binary</screen>
> +If you want to pass custom options to configure, you can set up the
> +DEB_BUILD_OPTIONS environment variable. For instance, if you want GUI

Here you could use the <envar> tag for the environment variable.

> +You can also pass some variables to the Makefile. For example, if you want
> +to compile with gcc 3.4 even if it's not the default compiler:
> +<screen>CC=gcc-3.4 DEB_BUILD_OPTIONS="--enable-gui" fakeroot debian/rules clean</screen>

This should be "binary", not "clean".

I've been thinking about this example and I think it's redundant.
Firstly passing (environment) variables like this is a standard Unix
skill, secondly this is wrong, the --cc option to configure should be
used instead.  So I would say just remove it.

Diego