[MPlayer-dev-eng] [PATCH] GUI: Potmeter button corrections

Ingo Brückl ib at wupperonline.de
Sat Mar 29 20:23:23 CET 2014

Hans-Dieter Kosch wrote on Wed, 26 Mar 2014 01:05:27 +0100:

> Ingo Brückl wrote:
>> Seems I really have to commence revising render.c now...

> I'm looking forward...


>> The job of the mouse handler is to return the exact mouse position, not
>> to "prettify" it. It's the job of the renderer to interpret the item
>> properties and to produce a pleasant result.

> Agreed.

I was just going to commit this patch when I realized that this will
cause a very unpleasant issue.

With a centered button all values from 0 to buttonsize/2 percent and
100-buttonsize/2 to 100 percent will end up in the same drawn button
position, or - to put it another way - dragging the button to the edges
will result in value changes but no button movement (for the width of

So, in weighing up the pros and cons of a "drifting" mouse pointer with
a definite (and different) position for all possible values and a centered
one that allows value changes without changing its position, I'm clearly
going for the "drifting" one.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pbutton_center.patch
Type: text/x-diff
Size: 1724 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20140329/5770faa5/attachment.bin>

More information about the MPlayer-dev-eng mailing list