[MPlayer-dev-eng] [PATCH] GUI: Potmeter button corrections

Hans-Dieter Kosch hdkosch at kabelbw.de
Sun Mar 30 01:51:46 CET 2014


Ingo Brückl wrote:

> I was just going to commit this patch when I realized that this will
> cause a very unpleasant issue.
> 
> With a centered button all values from 0 to buttonsize/2 percent and
> 100-buttonsize/2 to 100 percent will end up in the same drawn button
> position, or - to put it another way - dragging the button to the edges
> will result in value changes but no button movement (for the width of
> buttonsize/2).

Yes, I see. It's due to the min/max constraints in rendering.

The tie is that mouse handling and rendering are dependent on each other to 
obtain a correct visual feedback. Both have to regard the item dimensions and 
have to do matching forward/reverse calculations. Both do regard the potmeter 
size, but only rendering regards the potmeter's button size, while mouse does 
not. This is what my suggested patch aims to fix.

This could be coded by a common include-file, binding those dependencies clearly 
together.

Hans-Dieter


More information about the MPlayer-dev-eng mailing list