[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter
hdkosch at kabelbw.de
Fri Mar 28 03:02:18 CET 2014
Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Tue, 18 Mar 2014 02:03:28 +0100:
>> 1) If numphases == 1, hpotmeter gets its phase image drawn partially
>> according to the percentage of the value to be displayed
>> (SinglePhasePutImage), while vpotmeter gets it always fully drawn. How to
>> cope with this inconsistency?
> Nothing in the documentation indicates that numphases == 1 will be treated
> specially (and I don't see any point in not getting all phases by the skin
> designer), so I'd say: bye-bye, SinglePhasePutImage().
Yes, really, get rid of it.
>> 2) If numphases == 0, we get a division by zero in the rendering
>> (PutImage). Should this be trapped?
> No, I'd say numphases == 0 is an erroneous and invalid skin entry which ought
> result in a skin reject.
'reject' is what I actually meant by 'trapped'. Meanwhile I think, simply let it
run into SIGFPE as is. There can be more done wrong in skin definition which
would be huge effort to 'trap'. A skin designer should really know what he/she's
More information about the MPlayer-dev-eng