[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Ingo Brückl ib at wupperonline.de
Fri Mar 28 11:48:21 CET 2014

Hans-Dieter Kosch wrote on Fri, 28 Mar 2014 03:02:18 +0100:

> Ingo Brückl wrote:

>> Hans-Dieter Kosch wrote on Tue, 18 Mar 2014 02:03:28 +0100:

>>> 2) If numphases == 0, we get a division by zero in the rendering
>>> (PutImage). Should this be trapped?
>> No, I'd say numphases == 0 is an erroneous and invalid skin entry which
>> ought result in a skin reject.

> 'reject' is what I actually meant by 'trapped'. Meanwhile I think, simply
> let it run into SIGFPE as is. There can be more done wrong in skin
> definition which would be huge effort to 'trap'. A skin designer should
> really know what he/she's doing.

By 'reject' I meant: display an error and exit.

A skin designer can do a lot of weird things, but he/she mustn't be able to
cause a crash.


More information about the MPlayer-dev-eng mailing list