[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Ingo Brückl ib at wupperonline.de
Thu Mar 27 12:49:00 CET 2014

Hans-Dieter Kosch wrote on Tue, 18 Mar 2014 02:03:28 +0100:

> At this point, I came across 2 issues:

> 1) If numphases == 1, hpotmeter gets its phase image drawn partially
> according to the percentage of the value to be displayed
> (SinglePhasePutImage), while vpotmeter gets it always fully drawn. How to
> cope with this inconsistency?

Nothing in the documentation indicates that numphases == 1 will be treated
specially (and I don't see any point in not getting all phases by the skin
designer), so I'd say: bye-bye, SinglePhasePutImage().

(With a SinglePhasePutImage(), we'd have two, actually three or four
different kinds of phase images, a multi-phase one and a special one-phase
ones for each potmeter - fracturing width, height and(?) angle(?)... No dice!
Fortunately, no skin is using a one-phase image.)

> 2) If numphases == 0, we get a division by zero in the rendering
> (PutImage). Should this be trapped?

No, I'd say numphases == 0 is an erroneous and invalid skin entry which ought
result in a skin reject.


More information about the MPlayer-dev-eng mailing list