[MPlayer-dev-eng] [PATCH] show a correct image in a dvdnav menu

[KO Myung-Hun]

Reimar Döffinger wrote:
> On 05.03.2014, at 03:07, KO Myung-Hun <komh78 at gmail.com> wrote:
>> Hi/2.
>>
>> This patch show a correct image in a dvdnav menu instead of a white-box
>> cursor regardless of -sid, -slang and -nosub.
> 
> I can't imagine this is correct.

I agree. ^^

> For example I don't think the subtitle stream necessarily has ID 0, so this might break the menu overlay in cases where it's not.

You're right. Any hints to select the correct subtitle stream for a menu ?

> Next, as far as I know menus can actually be multi-lingual, and -slang should in this case be selecting the correct one for the language.

Yes. You're right. Unfortunately, I have no such DVD stuffs. Then how
about selecting arbitrary stream unless there is a subtitle stream for
-slang and -sid ?

And why mp_dvdnav_number_of_sub() return 0 for a menu ? There are any
other way to decide the number of the subtitle stream for a menu and it
is a subtitle stream for a menu ?

> I see a risk that some of the changes also will cause other issues, in particular the demux_mpg change seems very risky to me.

Why is it risky ? Although sub->id is selected there, it is decided
elsewhere by mp_property_do() or new_sh_sub_id() or ...

Finally, how about "already done" check of mp_property_sub() ? This
fixes the problem that -sid has a correct value for a subtitle stream
for a menu, a correct image does not appear because already read packets
are cleared by ds_free_packs().

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.28 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr