[MPlayer-dev-eng] [PATCH] show a correct image in a dvdnav menu

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Mar 5 08:37:05 CET 2014

On 05.03.2014, at 03:07, KO Myung-Hun <komh78 at gmail.com> wrote:
> Hi/2.
> This patch show a correct image in a dvdnav menu instead of a white-box
> cursor regardless of -sid, -slang and -nosub.

I can't imagine this is correct.
For example I don't think the subtitle stream necessarily has ID 0, so this might break the menu overlay in cases where it's not.
Next, as far as I know menus can actually be multi-lingual, and -slang should in this case be selecting the correct one for the language.
I see a risk that some of the changes also will cause other issues, in particular the demux_mpg change seems very risky to me.

More information about the MPlayer-dev-eng mailing list