[MPlayer-dev-eng] Crash with unsharp filter and x264 mp4 files

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 29 May 2012 19:48:48 +0200:

> On Tue, May 29, 2012 at 05:59:25PM +0200, Ingo Brückl wrote:
>> When playing those files with the unsharp filter (l7x7:1.7), there are some
>> greenish stripes at the top of the video

> That means it passes on the wrong size to get_image when doing direct
> rendering, see the recent change to vf_ass.c

The attached patch (by analogy with vf_ass.c) fixes the greenish stripes (if
it's ok I'd like to commit), but...

>> and after a while MPlayer crashes after printing "Ran out of numbered
>> images, expect crash. Filter before vo is broken." Without the filter,
>> everything is fine.

...it doesn't fix this crash.

> Does that still happen? It means that the usage count tracking is
> incorrect, however I haven't been able to trigger that case anymore
> with latest SVN.

Reverting r34949 fixes the crash.

Prior to r34949, number in vf.c's vf_get_image() is always 0, causing the
usage of just the first vf->imgctx.numbered_images. After r34949, number is
always -1, causing the search for a "free" vf->imgctx.numbered_images. This
is very often the first one (index 0) as well, but sometimes the first ones
aren't "free" and the longer the video plays, this number increases. (I have
actually no idea what I'm talking about here.)

Please see the log. Variable 'number' is printed at three different stages:

### number: -1          // this is the assignment at line 281
### number is -1        // this is after case MP_IMGTYPE_NUMBERED
### number set 0        // this is the assignment at line 334

This log is from start of the video until the crash. Maybe it helps. It is
interesting (at least to me) that the call prior to the crash used index 0,
and the next call couldn't find a "free" vf->imgctx.numbered_images, ending
with 50, so between two calls all the vf->imgctx.numbered_images have been
used up.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_unsharp.patch
Type: text/x-diff
Size: 639 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120530/63829645/attachment.bin>
-------------- next part --------------
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 2
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 2
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 3
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 4
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 4
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 5
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 6
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 6
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 6
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 6
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 7
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 8
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 8
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 8
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 8
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 9
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 9
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 9
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 9
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 10
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 10
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 11
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 11
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 12
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 12
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 13
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 14
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 15
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 16
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 17
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 18
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 18
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 18
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 19
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 20
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 20
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 21
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 21
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 22
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 22
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 23
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 23
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 24
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 24
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 24
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 24
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 25
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 26
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 26
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 27
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 28
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 29
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 30
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 31
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 32
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 33
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 34
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 34
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 35
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 36
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 37
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 38
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 39
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 40
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 40
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 41
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 41
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 42
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 42
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 43
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 43
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 44
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 44
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 45
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 45
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 46
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 46
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 47
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 47
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 48
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 48
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 49
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 49
### number: -1
### number: -1
### number: -1
### number: -1
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 0
### number: -1
### number is -1
### number set 50