[MPlayer-dev-eng] Crash with unsharp filter and x264 mp4 files

[Reimar Döffinger]

On Wed, May 30, 2012 at 06:21:03PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Tue, 29 May 2012 19:48:48 +0200:
> 
> > On Tue, May 29, 2012 at 05:59:25PM +0200, Ingo Brückl wrote:
> >> When playing those files with the unsharp filter (l7x7:1.7), there are some
> >> greenish stripes at the top of the video
> 
> > That means it passes on the wrong size to get_image when doing direct
> > rendering, see the recent change to vf_ass.c
> 
> The attached patch (by analogy with vf_ass.c) fixes the greenish stripes (if
> it's ok I'd like to commit), but...

There is no need for max, mpi->width must/will always be >= mpi->w
(basically, width is the allocate dimension and w the used dimension).

> >> and after a while MPlayer crashes after printing "Ran out of numbered
> >> images, expect crash. Filter before vo is broken." Without the filter,
> >> everything is fine.
> 
> ...it doesn't fix this crash.
> 
> > Does that still happen? It means that the usage count tracking is
> > incorrect, however I haven't been able to trigger that case anymore
> > with latest SVN.
> 
> Reverting r34949 fixes the crash.
> 
> Prior to r34949, number in vf.c's vf_get_image() is always 0, causing the
> usage of just the first vf->imgctx.numbered_images.

Obviously resulting in completely wrong output.
I know kind of what is going on, but not why.
My problem is that I can't reproduce it, can you please give exact
instructions for reproducing?
The most obvious explanation is that the decoder is allocating
frames that are never output.