[MPlayer-dev-eng] [PATCH] configure: fix ws2tcpip.h header check bug

Ingo Brückl ib at wupperonline.de
Wed Oct 26 19:48:45 CEST 2011


Diego Biurrun wrote on Wed, 26 Oct 2011 19:08:40 +0200:

>> > I have 1.7.x and AF_INET6 is also in /usr/include/cygwin/socket.h,
>>
>> Fine, but that's not the point.

> The point is that you need to develop for current Cygwin releases, not
> for the legacy ones.

No, that isn't the point either.

The point is that we currently check winsock2 headers even if configure has
determined that we don't have winsock2 on the machine. Later in the build
process we only include winsock2 headers if we really have winsock2.

For that very reason there are #if HAVE_WINSOCK2_H conditions in various
configure checks. Only for the headers, such a check is missing.

And, BTW, besides that the current behaviour clearly is a bug, it would be
nice if we could support more than just the very recent release of whatever.

Ingo


More information about the MPlayer-dev-eng mailing list