[MPlayer-dev-eng] [PATCH] configure: fix ws2tcpip.h header check bug

[Diego Biurrun]

On Tue, Oct 25, 2011 at 03:31:42AM +0200, Ingo Brückl wrote:
> Diego Biurrun wrote on Tue, 25 Oct 2011 03:24:25 +0200:
> 
> > On Tue, Oct 25, 2011 at 01:22:03AM +0200, Ingo Brückl wrote:
> >>
> >> Cygwin 1.5.25 only defines AF_INET6 through ws2tcpip.h, and
> >> ffmpeg/libavformat/network.h only includes ws2tcpip.h
> >> if HAVE_WINSOCK2_H (which isn't so in this case), so there
> >> is an error with "if (addr->sa_family == AF_INET6)".
> 
> > 1.5.25 is way outdated.
> 
> 1.5.25 isn't outdated. It is the legacy release.

That's what I call outdated.

> > I have 1.7.x and AF_INET6 is also in /usr/include/cygwin/socket.h,
> 
> Fine, but that's not the point.

The point is that you need to develop for current Cygwin releases, not
for the legacy ones.  Please upgrade and see if the problem can still
be reproduced.

Continuing to duplicate the build systems of external libraries is a
maintenance nightmare.

Diego