[MPlayer-dev-eng] [PATCH] configure: fix ws2tcpip.h header check bug

Ingo Brückl ib at wupperonline.de
Tue Oct 25 03:31:42 CEST 2011


Diego Biurrun wrote on Tue, 25 Oct 2011 03:24:25 +0200:

> On Tue, Oct 25, 2011 at 01:22:03AM +0200, Ingo Brückl wrote:
>>
>> Cygwin 1.5.25 only defines AF_INET6 through ws2tcpip.h, and
>> ffmpeg/libavformat/network.h only includes ws2tcpip.h
>> if HAVE_WINSOCK2_H (which isn't so in this case), so there
>> is an error with "if (addr->sa_family == AF_INET6)".

> 1.5.25 is way outdated.

1.5.25 isn't outdated. It is the legacy release.

> I have 1.7.x and AF_INET6 is also in /usr/include/cygwin/socket.h,

Fine, but that's not the point.

> so your patch seems unnecessary.

Is it really unnecessary to only check ws2tcpip.h if winsock2_h is enabled?

I don't think so.

Ingo


More information about the MPlayer-dev-eng mailing list