[MPlayer-dev-eng] [PATCH] configure: fix ws2tcpip.h header check bug

[Diego Biurrun]

On Wed, Oct 26, 2011 at 07:48:45PM +0200, Ingo Brückl wrote:
> Diego Biurrun wrote on Wed, 26 Oct 2011 19:08:40 +0200:
> 
> >> > I have 1.7.x and AF_INET6 is also in /usr/include/cygwin/socket.h,
> >>
> >> Fine, but that's not the point.
> 
> > The point is that you need to develop for current Cygwin releases, not
> > for the legacy ones.
> 
> No, that isn't the point either.
> 
> The point is that we currently check winsock2 headers even if configure has
> determined that we don't have winsock2 on the machine. Later in the build
> process we only include winsock2 headers if we really have winsock2.
> 
> For that very reason there are #if HAVE_WINSOCK2_H conditions in various
> configure checks. Only for the headers, such a check is missing.

Assuming that the situation you describe is a problem, your patch improves
nothing.  You still check non-winsock2 headers first even if winsock2 is
available.  In case those checks fail, we will 99% likely have winsock2
available, but you add some code to make sure that this is indeed the
case.

What you need to describe is a scenario where current configure produces
wrong results, running an extra check or two is no big deal.

> it would be nice if we could support more than just the very recent
> release of whatever.

Supporting old Cygwin releases is not worth maintaining hacks.

Diego