[MPlayer-dev-eng] [PATCH] Gui: remove unused variables

Ingo Brückl ib at wupperonline.de
Sun May 8 15:03:18 CEST 2011


Reimar Döffinger wrote on Sat, 7 May 2011 20:52:06 +0200:

> Hello,
> seems quite obvious to me, but in case someone has comments...

> -    if (guiIntfStruct.mpcontext) {
> -        audio_out = mpctx_get_audio_out(guiIntfStruct.mpcontext);
> -        video_out = mpctx_get_video_out(guiIntfStruct.mpcontext);
> -        mixer     = mpctx_get_mixer(guiIntfStruct.mpcontext);
> -    }
> +    if (guiIntfStruct.mpcontext)
> +        mixer = mpctx_get_mixer(guiIntfStruct.mpcontext);

I don't know enough of the non-gui stuff of MPlayer to tell whether
the mpctx_get_audio/video_out() calls may have required side effects.
If not so, no objections.

Ingo


More information about the MPlayer-dev-eng mailing list