[MPlayer-dev-eng] [PATCH] Gui: remove unused variables

[Reimar Döffinger]

On Sun, May 08, 2011 at 03:03:18PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sat, 7 May 2011 20:52:06 +0200:
> 
> > Hello,
> > seems quite obvious to me, but in case someone has comments...
> 
> > -    if (guiIntfStruct.mpcontext) {
> > -        audio_out = mpctx_get_audio_out(guiIntfStruct.mpcontext);
> > -        video_out = mpctx_get_video_out(guiIntfStruct.mpcontext);
> > -        mixer     = mpctx_get_mixer(guiIntfStruct.mpcontext);
> > -    }
> > +    if (guiIntfStruct.mpcontext)
> > +        mixer = mpctx_get_mixer(guiIntfStruct.mpcontext);
> 
> I don't know enough of the non-gui stuff of MPlayer to tell whether
> the mpctx_get_audio/video_out() calls may have required side effects.

No, they are just "getters" basically.
So removing video_out should be completely cosmetic, whereas as
others have pointed out removing audio_out changes behaviour a
bit when we play without audio.