[MPlayer-dev-eng] [PATCH] Gui: remove unused variables

Ingo Brückl ib at wupperonline.de
Sun May 8 15:16:51 CEST 2011


Martin Simmons wrote on Sun,  8 May 2011 02:27:15 +0100 (BST):

>> -        if (audio_out) {
>> +        if (mixer) {

> It's not quite the same: mpctx_get_audio_out can return NULL (e.g. -ao
> none) but mpctx_get_mixer can never return NULL.

Yes, that's true, but mixer is used here to only get the volume. Without
audio_out, it seems to safely return zero volume values. This will make the
volume controls now to stick and to snap back to zero when changed, which is
(from the viewpoint of the GUI) the more preferable behaviour than the one
prior to the patch where the controls could be changed, but without effect.

So this patch would have a nice side effect on unusable volume controls.

Ingo


More information about the MPlayer-dev-eng mailing list