[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Nicolas George]

L'octidi 28 ventôse, an CCXIX, Ingo Brückl a écrit :
>       if (use_gui) guiDie();       // or guiAbort()

doYouReallyInsistOnTheCamelCase? iFindItRatherUgly.

> I was simply thinking of something like
> and caring about this CONFIG_GUI later together with all the other ones.

I'd rather avoiding more ifdefs if a cleaner solution can be found
immediately. In this case, overriding the whole body of a function, the
solution of the function pointer seems quite easy and clean.

(Another solution would be tu put mp_die in a separate file and link with a
different version for the GUI, but that is more work.)

> I'd like to receive the MSGL_FATAL messages and try to inform the GUI user
> about these.

In this particular case, it may not be possible, as the message is about a
malloc failure. But anyway.

>	       The guiDie() (or guiAbort()) should clean up and destroy the GUI
> (if established).

Is there really something to do? Usually, if the application dies suddenly,
any GUI it has opened just disappears, and that is fine.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110318/e50f2933/attachment.pgp>