[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Ingo Brückl]

Nicolas George wrote on Fri, 18 Mar 2011 20:17:14 +0100:

> doYouReallyInsistOnTheCamelCase? iFindItRatherUgly.

It seems to be common practice throughout the gui files. The usage didn't
indicate any preference.

> I'd rather avoiding more ifdefs if a cleaner solution can be found
> immediately. In this case, overriding the whole body of a function, the
> solution of the function pointer seems quite easy and clean.

But isn't it necessary to decide which overriding should take place? As long
as mplayer is gmplayer I don't see how to avoid this.

Meanwhile I came to realize that it is better to put such a GUI information
call into the signal handler and/or exit functions rather than before an
abort() call.

> Is there really something to do? Usually, if the application dies suddenly,
> any GUI it has opened just disappears, and that is fine.

I've experienced failures that left the GUI on the screen unusably, possibly
not an abort.

Ingo