[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

Ingo Brückl ib at wupperonline.de
Fri Mar 18 17:19:03 CET 2011


Nicolas George wrote on Thu, 17 Mar 2011 10:01:20 +0100:

> Le septidi 27 ventôse, an CCXIX, Ingo Brückl a écrit :
>> > +static void mp_die(void)
>> > +{
>> > +    abort();
>> > +}
>> > +
>> The GUI would need a call to something like guiDie() there before.

> Would something like that suit you:

> static void mp_die_default(void) { abort(); }

> void (*mp_die)(void) = mp_die_default;

> And what do other think of it?

I was simply thinking of something like

  static void mp_die(void)
  {
  #ifdef CONFIG_GUI
      if (use_gui) guiDie();       // or guiAbort()
  #endif
      abort();
  }

and caring about this CONFIG_GUI later together with all the other ones.

> Remember that this kind of die is for catastrophic failures; you can not
> expect to be able to open a dialog box, for example.

I'd like to receive the MSGL_FATAL messages and try to inform the GUI user
about these. The guiDie() (or guiAbort()) should clean up and destroy the GUI
(if established).

Ingo


More information about the MPlayer-dev-eng mailing list