[MPlayer-dev-eng] [PATCH] doc: update/clarify policy about mixing cosmetic and functional chang

[Diego Biurrun]

On Mon, Dec 12, 2011 at 10:56:45AM +0100, Ingo Brückl wrote:
> Carl Eugen Hoyos wrote on Mon, 12 Dec 2011 09:29:31 +0000 (UTC):
> > Diego Biurrun <diego <at> biurrun.de> writes:
> 
> >> -6. Do not mix cosmetic changes (indentation, function/variable renaming and
> >> -   similar) with functional changes in a single commit. Instead, commit such
> >> -   changes as a separate commit of their own.
> >> +6. Do not mix large cosmetic changes (indentation, function/variable renaming
> >> +   and similar) with functional changes in a single commit. Instead, commit
> >> +   such changes as a separate commit of their own.
> 
> > I am against this change.
> > The current variant looks good to me.
> 
> +1
> 
> What is "large", what not.

Use your common sense.

> The distraction from functional changes doesn't depend on the amount of
> cosmetic changes.

Of course it does.  Just run some random file through uncrustify and
sprinkle a handful of small changes on top, compare to your last set
of commits.

Diego