[MPlayer-dev-eng] [PATCH] doc: update/clarify policy about mixing cosmetic and functional changes

[Clément Bœsch]

On Mon, Dec 12, 2011 at 09:29:31AM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> 
> > -6. Do not mix cosmetic changes (indentation, function/variable renaming and
> > -   similar) with functional changes in a single commit. Instead, commit such
> > -   changes as a separate commit of their own.
> > +6. Do not mix large cosmetic changes (indentation, function/variable renaming
> > +   and similar) with functional changes in a single commit. Instead, commit
> > +   such changes as a separate commit of their own.
> 
> I am against this change.
> The current variant looks good to me.
> 

Haha :)

Well, I must admit it looks pointless to split in multiple commits for
very small indent changes, but this is so much bikeshed I don't think it's
worth trying to convince ppl.

OTOH I think a "at your own discretion" or similar should be OK; why not
allow developers to split if they want (even if "silly"), but not require
it (except for large ones)?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111212/05f4c8d0/attachment.asc>