[MPlayer-dev-eng] [PATCH] doc: update/clarify policy about mixing cosmetic and functional changes

[Alexander Strasser]

Clément Bœsch wrote:
> On Mon, Dec 12, 2011 at 09:29:31AM +0000, Carl Eugen Hoyos wrote:
> > Diego Biurrun <diego <at> biurrun.de> writes:
> > 
> > > -6. Do not mix cosmetic changes (indentation, function/variable renaming and
> > > -   similar) with functional changes in a single commit. Instead, commit such
> > > -   changes as a separate commit of their own.
> > > +6. Do not mix large cosmetic changes (indentation, function/variable renaming
> > > +   and similar) with functional changes in a single commit. Instead, commit
> > > +   such changes as a separate commit of their own.

  This does still not forbid to do small cosmetic changes in separate commits.

> > I am against this change.
> > The current variant looks good to me.
> 
> Haha :)
> 
> Well, I must admit it looks pointless to split in multiple commits for
> very small indent changes, but this is so much bikeshed I don't think it's
> worth trying to convince ppl.
> 
> OTOH I think a "at your own discretion" or similar should be OK; why not
> allow developers to split if they want (even if "silly"), but not require
> it (except for large ones)?

  +1

  This is exactly what I am trying to say. Leave it to the developer and don't
flame developers for separating functional and cosmetic changes; even it it is
a one liner.

  OTOH if large cosmetic changes get mixed in, it is appropriate to object as
it makes it nearly impossible for other developers to do quick reviews on the
-cvslog mails.

  Alexander