[MPlayer-dev-eng] [PATCH] doc: update/clarify policy about mixing cosmetic and functional chang
ib at wupperonline.de
Mon Dec 12 10:56:45 CET 2011
Carl Eugen Hoyos wrote on Mon, 12 Dec 2011 09:29:31 +0000 (UTC):
> Diego Biurrun <diego <at> biurrun.de> writes:
>> -6. Do not mix cosmetic changes (indentation, function/variable renaming and
>> - similar) with functional changes in a single commit. Instead, commit such
>> - changes as a separate commit of their own.
>> +6. Do not mix large cosmetic changes (indentation, function/variable renaming
>> + and similar) with functional changes in a single commit. Instead, commit
>> + such changes as a separate commit of their own.
> I am against this change.
> The current variant looks good to me.
What is "large", what not.
The distraction from functional changes doesn't depend on the amount of
cosmetic changes. Either split them or mix them.
More information about the MPlayer-dev-eng