[MPlayer-dev-eng] [PATCH] doc: update/clarify policy about mixing cosmetic and functional changes

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Dec 12 10:29:31 CET 2011


Diego Biurrun <diego <at> biurrun.de> writes:

> -6. Do not mix cosmetic changes (indentation, function/variable renaming and
> -   similar) with functional changes in a single commit. Instead, commit such
> -   changes as a separate commit of their own.
> +6. Do not mix large cosmetic changes (indentation, function/variable renaming
> +   and similar) with functional changes in a single commit. Instead, commit
> +   such changes as a separate commit of their own.

I am against this change.
The current variant looks good to me.

Carl Eugen



More information about the MPlayer-dev-eng mailing list