[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Fri, Oct 08, 2010 at 02:34:39PM -0700, Dirk Porezag wrote:
> OK now I have found the culprit. The old version did not even implement 
> UPDATE_SCREENINFO in config(). With VO_MGA I don't see how the screen info could 
> be updated (since it's unknown) but the current version does this anyway and 
> once aspect() is called, you get something like a division by zero and as a 
> result a huge vo_dwidth or vo_dheight that will cause the mga_config ioctl() to 
> fail.
> 
> The way to get around this is to change the patched version as follows:
> 
> --- mga_template.c.sav  2010-10-08 23:14:51.000000000 +0200
> +++ mga_template.c      2010-10-08 23:19:05.000000000 +0200
> @@ -352,10 +352,10 @@
>    case VOCTRL_UPDATE_SCREENINFO:
>  #ifdef VO_XMGA
>        update_xinerama_info();
> +      return VO_TRUE;
>  #else
> -      aspect_save_screenres(vo_screenwidth, vo_screenheight);
> +      return VO_FALSE;
>  #endif
> -      return VO_TRUE;
>    }
>    return VO_NOTIMPL;
>  }

That's wrong, that would require the MGA code to do all the aspect
handling itself - hwoever not duplicating that code is the point
of the patch.
Please see if the issue is gone with SVN r32452.