[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Dirk Porezag]

OK now I have found the culprit. The old version did not even implement 
UPDATE_SCREENINFO in config(). With VO_MGA I don't see how the screen info could 
be updated (since it's unknown) but the current version does this anyway and 
once aspect() is called, you get something like a division by zero and as a 
result a huge vo_dwidth or vo_dheight that will cause the mga_config ioctl() to 
fail.

The way to get around this is to change the patched version as follows:

--- mga_template.c.sav  2010-10-08 23:14:51.000000000 +0200
+++ mga_template.c      2010-10-08 23:19:05.000000000 +0200
@@ -352,10 +352,10 @@
   case VOCTRL_UPDATE_SCREENINFO:
 #ifdef VO_XMGA
       update_xinerama_info();
+      return VO_TRUE;
 #else
-      aspect_save_screenres(vo_screenwidth, vo_screenheight);
+      return VO_FALSE;
 #endif
-      return VO_TRUE;
   }
   return VO_NOTIMPL;
 }


The total svn diff of the resulting updated patch is attached.

Regards,
Dirk



----- Ursprüngliche Mail ----
> Von: Dirk Porezag <porezag at yahoo.com>
> An: mplayer-dev-eng at mplayerhq.hu
> Gesendet: Freitag, den 8. Oktober 2010, 22:07:37 Uhr
> Betreff: Re: [MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI 
>mode
> 
> Everything OK if "-screenw <width> -screenh <height>" are used.  Without this 
>the 
>
> MGA_VID_CONFIG ioctl fails, causing all the rest to fail as  well. The reason 
>is 
>
> most likely that the screen width/height used in the  ioctl is crazy. I'll dig 
>a 
>
> little deeper, comparing with the older working  version. But at any rate I'd 
>say 
>
> that whenever screen width and height are 0  in preinit() one might just set 
>them 
>
> to the movie width/height. I think that  in essence this is what the old 
>version 
>
> did.
> 
> 
> ----- Ursprüngliche  Mail ----
> > Von: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> >  An: mplayer-dev-eng at mplayerhq.hu
> >  Gesendet: Freitag, den 8. Oktober 2010, 20:33:28 Uhr
> > Betreff: Re:  [MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI 
>
> >mode
> > 
> > On Fri, Oct 08, 2010 at 08:13:29PM +0200, Reimar  Döffinger wrote:
> > > On  Fri, Oct 08, 2010 at 10:58:10AM +0200,  Diego Biurrun wrote:
> > > > On Thu,  Oct 07, 2010 at 08:21:01AM  +0200, Reimar Döffinger wrote:
> > > > > On  Thu, Oct 07, 2010  at 08:11:44AM +0200, Reimar Döffinger wrote:
> > > > >  > I  can have a look now that I know where the issues are.
> > > > > 
> > > > > Actually, I think it would be easier if you can tell me  which  code
> > > > > exactly breaks witch screen width/height  = 0 and  why.
> > > > > Attached is an updated version of the  patch that should  work
> > > > > right at least if you  manually specify -screenwidth  -screenheight.
> > > > 
> >  > > I get a 1-2 pixel colorkey (green)  border at the right and  bottom 
>sides
> > > > of the window with your patch   applied.
> > > 
> > > With GUI? Without GUI? In fullscreen  also?
> > 
> > And  note that unless you apply the other patch as  well, movements
> > will not work,  so you could get this effect if  e.g. due to an
> > off-by-one bug your window  manager move the window  slightly
> > at any  time.
> >  _______________________________________________
> > MPlayer-dev-eng   mailing list
> > MPlayer-dev-eng at mplayerhq.hu
> > https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> > 
> 
> 
> _______________________________________________
> MPlayer-dev-eng  mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmga.diff.dirk
Type: application/octet-stream
Size: 5719 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101008/8e369b4a/attachment.obj>