[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Dirk Porezag]

OK understood. I saw you fixed the issue where it arises - in aspect.c. Works 
now.
So as far as I'm concerned I'm happy with the state after applying the two 
patches now. VO_MGA still does not work correctly in GUI mode (the movie plays 
and the GUI comes up but it cannot be used). But this was the case in older 
releases as well and I think that the combination VO_MGA + GUI hardly makes 
sense anyway since VO_MGA doesn't use any X11 stuff and without X11 there's no 
window manager that could handle the GUI control window correctly.

Would be great to get the patches into HEAD. Thanks for fixing!



----- Ursprüngliche Mail ----
> Von: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> An: mplayer-dev-eng at mplayerhq.hu
> Gesendet: Samstag, den 9. Oktober 2010, 3:33:50 Uhr
> Betreff: Re: [MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI 
>mode
> 
> On Fri, Oct 08, 2010 at 02:34:39PM -0700, Dirk Porezag wrote:
> > OK now I  have found the culprit. The old version did not even implement 
> >  UPDATE_SCREENINFO in config(). With VO_MGA I don't see how the screen info 
>could 
>
> > be updated (since it's unknown) but the current version does this  anyway and 
>
> > once aspect() is called, you get something like a division  by zero and as a 

> > result a huge vo_dwidth or vo_dheight that will cause  the mga_config ioctl() 
>to 
>
> > fail.
> > 
> > The way to get around  this is to change the patched version as follows:
> > 
> > ---  mga_template.c.sav  2010-10-08 23:14:51.000000000 +0200
> > +++  mga_template.c      2010-10-08 23:19:05.000000000 +0200
> >  @@ -352,10 +352,10 @@
> >    case  VOCTRL_UPDATE_SCREENINFO:
> >  #ifdef VO_XMGA
> >         update_xinerama_info();
> > +      return  VO_TRUE;
> >  #else
> > -       aspect_save_screenres(vo_screenwidth, vo_screenheight);
> > +       return VO_FALSE;
> >  #endif
> > -       return VO_TRUE;
> >    }
> >    return  VO_NOTIMPL;
> >  }
> 
> That's wrong, that would require the MGA code  to do all the aspect
> handling itself - hwoever not duplicating that code is  the point
> of the patch.
> Please see if the issue is gone with SVN  r32452.
> _______________________________________________
> MPlayer-dev-eng  mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>