[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

Dirk Porezag porezag at yahoo.com
Sun Oct 3 00:45:38 CEST 2010


>  I think it should be ok, however it should be one patch per  issue it fixes

> (and with a short explanation which issue that  is).
Understood & agreed. Here we go:

vo_xmga-fix-move.patch:
PROBLEM: Following recent cleanup actions in libvo/x11_common.c and related 
files, the vo_xmga does not move the movie screen with the X window any more. 
This fix introduces a VO_EVENT_MOVE event which is used in the vo_xmga module to 
fix the movie screen location after a move. Other VOs are not impacted.

vo_xmga-fix-gui-crash.patch:
PROBLEM: Following recent updates in the libvo section, the X11 drawable 
vo_window is not initialized correctly any more in GUI mode. This leads to an 
immediate crash of mplayer upon starting. The patch fixes this behavior.

vo_xmga-fix-gui-fullscreen-flicker.patch:
PROBLEM: Following recent changes in libvo/x11_common.c, the check_resize() 
function is now called much more often than in previous releases. This has 
exposed a bug in libvo/mga_template.c:set_window(): The way the vo_dwidth and 
vo_dheight variables are set here is inconsistent with what 
libvo/x11_common:check_resize() does and leads to flickering due to quickly 
oscillating changes of these variables. vo_dwidth and vo_dheight should not be 
set by set_window() at all but managed by the more generic (vo independent) 
functions. This patch fixes the issue (and the flickering).

Thanks,
Dirk


-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_xmga-fix-gui-crash.patch
Type: application/octet-stream
Size: 369 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101002/cd54cede/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_xmga-fix-gui-fullscreen-flicker.patch
Type: application/octet-stream
Size: 751 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101002/cd54cede/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_xmga-fix-move.patch
Type: application/octet-stream
Size: 1466 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101002/cd54cede/attachment-0002.obj>


More information about the MPlayer-dev-eng mailing list