[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Sat, Oct 02, 2010 at 02:35:15PM -0700, Dirk Porezag wrote:
> > > Actually,  removing the #ifdef  VO_XMGA in mga_template.c:set_window does not 
> >
> >
> 
> > >  help much here.
> > 
> > I never said so, I only said it can be removed (since it  is pointless).
> >
> Well, I tried removing this part and then the X window used for displaying the 
> movie was not aligned with the mga_vid based rectangle where the movie was 
> shown. I haven't figured out yet why but I'm inclined to leave this part of the 
> code as is for now since it's working with it and it isn't without.
> 
> > > I  would really be grateful if someone could 
> > > explain to me why  check_resize() is called ALWAYS whenever WinID > 0 (I 
> > > refer to line  821 in x11_common.c).
> > 
> > Because only one client can request ConfigureNotify  events, and if WinID is > 
> 
> > 0
> > someone else already may be using it, so in  general we will not receive any.
> > 
> OK. So I left this part of the code alone and followed your suggestion from the 
> first 
> 
> reply. Added a VO_EVENT_MOVE event in x11_common.c:check_resize() and 
> used this new event in vo_xmga to update the on-screen area managed by mga_vid. 
> Modified patch is included, it should now have minimal impact on other VOs and 
> works for me. Let me know if you think that additional changes are necessary.

I think it should be ok, however it should be one patch per issue it fixes
(and with a short explanation which issue that is).