[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode
Reimar.Doeffinger at gmx.de
Sun Oct 3 09:28:05 CEST 2010
On Sat, Oct 02, 2010 at 03:45:38PM -0700, Dirk Porezag wrote:
> > I think it should be ok, however it should be one patch per issue it fixes
> > (and with a short explanation which issue that is).
> Understood & agreed. Here we go:
> PROBLEM: Following recent cleanup actions in libvo/x11_common.c and related
> files, the vo_xmga does not move the movie screen with the X window any more.
> This fix introduces a VO_EVENT_MOVE event which is used in the vo_xmga module to
> fix the movie screen location after a move. Other VOs are not impacted.
Ok, I'll apply that (with some cosmetics) once the other stuff is solved.
> PROBLEM: Following recent updates in the libvo section, the X11 drawable
> vo_window is not initialized correctly any more in GUI mode. This leads to an
> immediate crash of mplayer upon starting. The patch fixes this behavior.
> PROBLEM: Following recent changes in libvo/x11_common.c, the check_resize()
> function is now called much more often than in previous releases. This has
> exposed a bug in libvo/mga_template.c:set_window(): The way the vo_dwidth and
> vo_dheight variables are set here is inconsistent with what
> libvo/x11_common:check_resize() does and leads to flickering due to quickly
> oscillating changes of these variables. vo_dwidth and vo_dheight should not be
> set by set_window() at all but managed by the more generic (vo independent)
> functions. This patch fixes the issue (and the flickering).
Since now finally with you there is someone available to test things,
I'd like to suggest the more radical approach as in attached patch.
This hopefully will keep MGA working beyond future changes, e.g.
aspect scaling and panscan in windowed mode should then work without
any further changes.
You will need to keep that move patch on top of it, and it likely
has some bugs, could you test (with and without Gui, and also
-vo mga not only xmga)?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5688 bytes
Desc: not available
More information about the MPlayer-dev-eng