[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), what is performance?

[Diego Biurrun]

On Sun, May 30, 2010 at 11:08:50AM +0200, Thomas Orgis wrote:
> Am Sun, 30 May 2010 10:30:21 +0200
> schrieb Diego Biurrun <diego at biurrun.de>: 
> 
> > Please consistently use K&R style: space between keyword and (,
> > { on the same line as the keyword.
> 
> > *sh, more below
> 
> > There are some long lines that you could easily break.
> 
> Thanks for your remarks, but as I see strong debate on technical
> aspects, I humbly ask for some tolerance on the style... this patch
> version is the experiment to cram all possible ways of input into the
> source, with the preprocessor flags as quick switches... it's hacky, I
> know. Once the weird performance issues are settled, I intend to strip
> the patch again, to leave the code that remains.

See my other mail, I was trying to explore the possibility of merging
this in some form already and then working out the details.

In any case style nits should not take you more than a minute to fix.
For the next round of patches you can keep it in mind and save even
more time :)

Diego