[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), what is performance?

[Thomas Orgis]

Am Sun, 30 May 2010 10:30:21 +0200
schrieb Diego Biurrun <diego at biurrun.de>: 

> Please consistently use K&R style: space between keyword and (,
> { on the same line as the keyword.

> *sh, more below

> There are some long lines that you could easily break.

Thanks for your remarks, but as I see strong debate on technical
aspects, I humbly ask for some tolerance on the style... this patch
version is the experiment to cram all possible ways of input into the
source, with the preprocessor flags as quick switches... it's hacky, I
know. Once the weird performance issues are settled, I intend to strip
the patch again, to leave the code that remains.

> > +#ifdef AD_MPG123_CALLBACK
> 
> This was introduced in which version of mpg123?

This is the switch for the _handle API, which has been added in mpg123
1.12 . In functionality it's similar to the fd-based callback API,
which has been available since version 1.0.0 .
Again, please regard this version of the patch as an experiment.

> > +            if (++con->mean_count > ((unsigned int)-1)/2)
> > +                con->mean_count = ((unsigned int)-1)/4;
> 
> Spaces around operators would make this more readable.

Hm, OK, that applies to the code without experiment, too.


Alrighty then,

Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100530/6a4dea5c/attachment.pgp>