[MPlayer-dev-eng] [PATCH] Support CineForm HD

[Reimar Döffinger]

On Sat, Mar 06, 2010 at 03:01:38PM +0100, Steinar H. Gunderson wrote:
> I'm unsure about the registry part -- is there another, better way of doing
> this? CineForm assumes these keys are set by the installer before the codec
> is used.

The loader should read registry data, it would e.g. be possible to write a default
registry file with these settings, or ship with a default one that can be installed
if desired or so.

> +    // Hacks for CineForm.
> +    if (value) {
> +      if (strcmp(value, "Resolution") == 0) {
> +        *data = 0x3e8;
> +        return 0;
> +      }
> +      if (strcmp(value, "PixelFormats") == 0) {
> +        *data = 0xffff;
> +        return 0;
> +      }
> +    }

Looks to me like that would always return those values for
those keys, independent in which path they are queried or
whether someone added registry keys to override those.
With such generic names that's far too likely to cause issues,
at most this would be acceptable after the check for the keys
in the registry file.