[MPlayer-dev-eng] [PATCH] Support CineForm HD

[Steinar H. Gunderson]

On Sat, Mar 06, 2010 at 06:43:07PM +0100, Reimar Döffinger wrote:
>> I'm unsure about the registry part -- is there another, better way of doing
>> this? CineForm assumes these keys are set by the installer before the codec
>> is used.
> The loader should read registry data, it would e.g. be possible to write a default
> registry file with these settings, or ship with a default one that can be installed
> if desired or so.

OK, so you're essentially saying there's no current support for preloading
the registry? So, if we put something in create_registry(), and the user
updates MPlayer, what will we do with the existing registry?

> Looks to me like that would always return those values for
> those keys, independent in which path they are queried or
> whether someone added registry keys to override those.
> With such generic names that's far too likely to cause issues,
> at most this would be acceptable after the check for the keys
> in the registry file.

Sure, if we put the code in there the checks should be more robust.

/* Steinar */
-- 
Homepage: http://www.sesse.net/