[MPlayer-dev-eng] [PATCH] unified timing patch for H264

Pásztor Szilárd bartosteka at freemail.hu
Mon Aug 30 18:42:11 CEST 2010


Reimar Döffinger:
For the other on, the grammar in this comment is... let's say "very strange" :-)
> // The key to maintain A-V sync is to don't touch PTS until the proper frame

Maybe a "is reached" could be put on the end, otherwise it's ok... :)

> Also I think your sh_video->pts updating algorithm doesn't take into
> account wrapping or resetting timestamps (very common for DVDs but also
> exists for other formats).

Such wraps or resets are automatically "taken into account", ie. if the new
PTS differs more than 20 frametimes (tipically still less than one second), the
PTS won't get replaced, but last_pts still gets set, so that at the next frame
we already have the "jumped" PTS to begin from... The same thing happens at
seeking: PTS has a big jumps, and the "algorithm" catches up in one frame time.
Maybe framestep_found could be reset to 0 in this case too.


More information about the MPlayer-dev-eng mailing list