[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Reimar Döffinger]

On Sun, Aug 29, 2010 at 09:36:37PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> > This changes behaviour for all cases and codecs where mpi is NULL or
> > the new special type, but the idea was to _only_ change behaviour for
> > fields in H.264.
> > Which means this code must behave 100% identical to before unless it
> > gets a mpi->type == MP_IMGTYPE_NULL. And that it doesn't with your patch.
> 
> True, it was a mistake. Now I changed the patches so that the right check
> is used, all comments are processed and the full_frame thing is moved to
> the nocorrect-pts patch.

Reorder patch seems ok to me.
For the other on, the grammar in this comment is... let's say "very strange" :-)
> // The key to maintain A-V sync is to don't touch PTS until the proper frame
Also I think your sh_video->pts updating algorithm doesn't take into account
wrapping or resetting timestamps (very common for DVDs but also exists for other
formats).
I think would be preferable to extract that out and discuss separately.