[MPlayer-dev-eng] [PATCH] unified timing patch for H264
Reimar.Doeffinger at gmx.de
Mon Aug 30 19:18:56 CEST 2010
On Mon, Aug 30, 2010 at 06:42:11PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> For the other on, the grammar in this comment is... let's say "very strange" :-)
> > // The key to maintain A-V sync is to don't touch PTS until the proper frame
> Maybe a "is reached" could be put on the end, otherwise it's ok... :)
Not really, "The key to maintain" means you are talking about a key you
want to maintain, what you meant is "The key to maintaining".
And "to don't" doesn't work at all, "to not" would.
It still is more complex grammar than necessary or sensible I think.
> Such wraps or resets are automatically "taken into account", ie. if the new
> PTS differs more than 20 frametimes (tipically still less than one second), the
> PTS won't get replaced, but last_pts still gets set
I missed last_pts would get set.
More information about the MPlayer-dev-eng