[MPlayer-dev-eng] [RFC] libavutil/x86_cpu.h

[Diego Biurrun]

On Tue, Aug 17, 2010 at 07:34:45PM +0200, Reimar Döffinger wrote:
> On Tue, Aug 17, 2010 at 01:12:21PM +0200, Diego Biurrun wrote:
> > On Tue, Aug 10, 2010 at 04:04:05PM +0200, Reimar Döffinger wrote:
> > > On Tue, Aug 10, 2010 at 01:29:44PM +0200, Diego Biurrun wrote:
> > > > > And right now, only if we change configure to generate two defines for the
> > > > > same thing if FFmpeg renames then
> > > > > And even that only works if FFmpeg does not use those old names for something
> > > > > else.
> > > > 
> > > > The ARCH_ #defines are also used in MPlayer in various places, they will
> > > > not go away.
> > > > 
> > > > We seem to be misunderstanding each other.  Could you please give an
> > > > example where anything can go wrong?  I cannot see how copying that
> > > > header can introduce problems, ever.
> > > 
> > > HAVE_EBX_AVAILABLE being renamed, for example?
> > 
> > This does no damage at all.  The copied header will not be affected by
> > such a rename, everything will continue to work as it should.
> 
> As I said, only as long as we keep our own configure check for it,
> which we preferably will not in the longer term.

If it is used within MPlayer itself, then we need the configure check,
there is no way around this.

I'm somewhat confused what your remaining point is, if there is one
at all, and what your opinion is regarding my patch/suggestion.

Diego