[MPlayer-dev-eng] [RFC] libavutil/x86_cpu.h

[Reimar Döffinger]

On Tue, Aug 17, 2010 at 01:12:21PM +0200, Diego Biurrun wrote:
> On Tue, Aug 10, 2010 at 04:04:05PM +0200, Reimar Döffinger wrote:
> > On Tue, Aug 10, 2010 at 01:29:44PM +0200, Diego Biurrun wrote:
> > > > And right now, only if we change configure to generate two defines for the
> > > > same thing if FFmpeg renames then
> > > > And even that only works if FFmpeg does not use those old names for something
> > > > else.
> > > 
> > > The ARCH_ #defines are also used in MPlayer in various places, they will
> > > not go away.
> > > 
> > > We seem to be misunderstanding each other.  Could you please give an
> > > example where anything can go wrong?  I cannot see how copying that
> > > header can introduce problems, ever.
> > 
> > HAVE_EBX_AVAILABLE being renamed, for example?
> 
> This does no damage at all.  The copied header will not be affected by
> such a rename, everything will continue to work as it should.

As I said, only as long as we keep our own configure check for it,
which we preferably will not in the longer term.