[MPlayer-dev-eng] [PATCH] Change >8 memalign() to av_malloc() under libmpcodecs, avoiding crash under Win32

Zuxy Meng zuxy.meng at gmail.com
Wed Apr 14 12:48:49 CEST 2010


2010/4/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> On Wed, Apr 14, 2010 at 09:05:39AM +0800, Zuxy Meng wrote:
>> 2010/4/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>> > On Wed, Apr 14, 2010 at 01:47:45AM +0800, Zuxy Meng wrote:
>> >> As $title, pairing free() changed to av_free() too.
>> >
>> > I've been working on it a bit as well, but I concluded the mem.h
>> > include in mp_image.h is unacceptable.
>>
>> Would u enlighten me a bit on the reasoning?
>
> It means that all files including it (which is a _huge_ amount, basically
> anything realted to video) will have that include.
> Means higher risk of name collissions, probably higher compilation times,
> and people will probably forget to include mem.h in the C files where they
> should because it is already included indirectly.

Diff updated as per Diego's and Reimar's comments.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_malloc.diff
Type: application/octet-stream
Size: 7468 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100414/9d71a7c8/attachment.obj>


More information about the MPlayer-dev-eng mailing list