[MPlayer-dev-eng] [PATCH] Change >8 memalign() to av_malloc() under libmpcodecs, avoiding crash under Win32

[Zuxy Meng]

2010/4/14 Zuxy Meng <zuxy.meng at gmail.com>:
> 2010/4/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>> On Wed, Apr 14, 2010 at 09:05:39AM +0800, Zuxy Meng wrote:
>>> 2010/4/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>>> > On Wed, Apr 14, 2010 at 01:47:45AM +0800, Zuxy Meng wrote:
>>> >> As $title, pairing free() changed to av_free() too.
>>> >
>>> > I've been working on it a bit as well, but I concluded the mem.h
>>> > include in mp_image.h is unacceptable.
>>>
>>> Would u enlighten me a bit on the reasoning?
>>
>> It means that all files including it (which is a _huge_ amount, basically
>> anything realted to video) will have that include.
>> Means higher risk of name collissions, probably higher compilation times,
>> and people will probably forget to include mem.h in the C files where they
>> should because it is already included indirectly.
>
> Diff updated as per Diego's and Reimar's comments.

If nobody rejects I'll apply the attached diff tomorrow.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_malloc.diff
Type: application/octet-stream
Size: 6429 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100419/dd4e9d4a/attachment.obj>