[MPlayer-dev-eng] [PATCH] Change >8 memalign() to av_malloc() under libmpcodecs, avoiding crash under Win32

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Apr 14 07:57:28 CEST 2010


On Wed, Apr 14, 2010 at 09:05:39AM +0800, Zuxy Meng wrote:
> 2010/4/14 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > On Wed, Apr 14, 2010 at 01:47:45AM +0800, Zuxy Meng wrote:
> >> As $title, pairing free() changed to av_free() too.
> >
> > I've been working on it a bit as well, but I concluded the mem.h
> > include in mp_image.h is unacceptable.
> 
> Would u enlighten me a bit on the reasoning?

It means that all files including it (which is a _huge_ amount, basically
anything realted to video) will have that include.
Means higher risk of name collissions, probably higher compilation times,
and people will probably forget to include mem.h in the C files where they
should because it is already included indirectly.



More information about the MPlayer-dev-eng mailing list