[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Francesco Lavra]

Following the latest commits to MPlayer, in attachment the updated
patches.
The first one only contains some cosmetic changes that add to those
already applied by Carl Eugen.

On Wed, 2009-10-28 at 18:35 +0100, Diego Biurrun wrote:
> On Sat, Oct 24, 2009 at 07:33:07PM +0200, Francesco Lavra wrote:
> > 
> > --- libmpcodecs/dec_teletext.h	(revision 29796)
> > +++ libmpcodecs/dec_teletext.h	(working copy)
> > @@ -23,7 +23,22 @@
> >  #ifndef MPLAYER_DEC_TELETEXT_H
> >  #define MPLAYER_DEC_TELETEXT_H
> >  
> > +typedef struct tt_param_s {
> > +    char *device;  ///< teletext device
> > +    int format;    ///< teletext display format
> > +    int page;      ///< start teletext page
> > +    int lang;      ///< primary language code
> > +} tt_param_t;
> 
> The _t namespace is reserved for POSIX, don't invade it.

Changed typedef from tt_param_t to tt_params

> > +#define VBI_CONTROL_FALSE              0
> > +#define VBI_CONTROL_TRUE               1
> > +#define VBI_CONTROL_UNKNOWN            -1
> 
> Could be aligned.

Done by Carl Eugen

> > +#ifdef CONFIG_TV_TELETEXT
> >  int teletext_control(void* p, int cmd, void *arg);
> > +#else
> > +#define teletext_control(p, cmd, arg) VBI_CONTROL_FALSE
> > +#endif
> 
> Is the #ifdef necessary?

I'm afraid it is, the alternative would be putting ifdefs at every call
to that function. The reason behind this necessary change is that now
teletext_control() is a truly global function, called from different
parts, while before this patches it was a kind of private function
belonging to the TV input layer, called exclusively from inside
stream/tvi_*.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_cosmetics.patch
Type: text/x-patch
Size: 2139 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20091031/24f2b1e5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_teletext.patch
Type: text/x-patch
Size: 15715 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20091031/24f2b1e5/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_lavf.patch
Type: text/x-patch
Size: 539 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20091031/24f2b1e5/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04_dvb_teletext.patch
Type: text/x-patch
Size: 9932 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20091031/24f2b1e5/attachment-0003.bin>