[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Diego Biurrun]

On Sat, Oct 24, 2009 at 07:33:07PM +0200, Francesco Lavra wrote:
> 
> --- libmpcodecs/dec_teletext.h	(revision 29796)
> +++ libmpcodecs/dec_teletext.h	(working copy)
> @@ -23,7 +23,22 @@
>  #ifndef MPLAYER_DEC_TELETEXT_H
>  #define MPLAYER_DEC_TELETEXT_H
>  
> +typedef struct tt_param_s {
> +    char *device;  ///< teletext device
> +    int format;    ///< teletext display format
> +    int page;      ///< start teletext page
> +    int lang;      ///< primary language code
> +} tt_param_t;

The _t namespace is reserved for POSIX, don't invade it.

> +#define VBI_CONTROL_FALSE              0
> +#define VBI_CONTROL_TRUE               1
> +#define VBI_CONTROL_UNKNOWN            -1

Could be aligned.

> +#ifdef CONFIG_TV_TELETEXT
>  int teletext_control(void* p, int cmd, void *arg);
> +#else
> +#define teletext_control(p, cmd, arg) VBI_CONTROL_FALSE
> +#endif

Is the #ifdef necessary?

Diego