[MPlayer-dev-eng] VA API support for MPlayer

[Diego Biurrun]

On Mon, Jan 05, 2009 at 11:34:09AM +0100, Gwenole Beauchesne wrote:
> 
> On Wed, 24 Dec 2008, Diego Biurrun wrote:
> 
> > Please use our standard license header instead.
> 
> Well, I looked for a good looking license header, and I reached to the
> one from vo_wii.c. I will grab another one then.

vo_wii.c never had such a license header.  Whatever, just use the
standard one.

> >> +typedef struct {
> >> +  VADisplay display;
> >> +  VAConfigID config_id;
> >> +  VAContextID context_id;
> >> +} vaapi_context_t;
> > 
> > The _t namespace is reserved by POSIX, use another name, possibly
> > drop the typedef.
> 
> Would something like VAAPI_Context be acceptable? i.e. VAAPI_ prefix + 
> camel-case typename? I'd prefer sticking to lower-case for identifiers and 
> use something different for type names.

I think a better idea would be to drop the typedef.

Diego