[MPlayer-dev-eng] VA API support for MPlayer
Gwenole Beauchesne
gbeauchesne at splitted-desktop.com
Mon Jan 5 11:34:09 CET 2009
Hi,
On Wed, 24 Dec 2008, Diego Biurrun wrote:
> Please use our standard license header instead.
Well, I looked for a good looking license header, and I reached to the one from
vo_wii.c. I will grab another one then.
OK, 4-space indentation, no tabs. Understood.
>> @@ -101,6 +106,36 @@
>>
>> +#undef printf
>
> Ahem...
Sorry, leftover from (unused) dump_data() function. ;-)
>> +typedef struct {
>> + VADisplay display;
>> + VAConfigID config_id;
>> + VAContextID context_id;
>> +} vaapi_context_t;
>
> The _t namespace is reserved by POSIX, use another name, possibly
> drop the typedef.
Would something like VAAPI_Context be acceptable? i.e. VAAPI_ prefix +
camel-case typename? I'd prefer sticking to lower-case for identifiers and
use something different for type names.
Thanks,
Gwenole.
More information about the MPlayer-dev-eng
mailing list