[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Francesco Lavra]

On Sun, 2009-08-02 at 16:08 +0200, Francesco Lavra wrote:
> On Sun, 2009-08-02 at 13:30 +0200, Diego Biurrun wrote:
> > > > Is the #ifdef necessary?
> > > It is not really necessary, I just followed the coding style present in
> > > that file (see the 30 or so lines above my addition)
> >
> > Those #ifdefs should be necessary or else they should be removed.
> 
> Removed
> 
> > > > I think this patch would be smaller if you moved stuff around with 'svn
> > > > cp' before creating the diff.
> > > I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> > > code from tv.h
> > 
> > You are copying code.  Use svn cp.
> 
> Done

Second patch of the series:
- Replaced TVI_CONTROL_TRUE, TVI_CONTROL_FALSE and TVI_CONTROL_UNKNOWN
constants in /libmpcodecs/dec_teletext.c with VBI_CONTROL_TRUE,
VBI_CONTROL_FALSE and VBI_CONTROL_UNKNOWN
- Added TVI_CONTROL_GET_VBI_PTR definition in stream/tv.h and
implementation of relevant control in stream/tvi_v4l.c,
stream/tvi_v4l2.c and stream/tvi_dshow.c
- Modified stream/tv.c, command.c and mpcommon.c such that
teletext_control() is called directly, instead of passing through TVI
handle control function
- Moved teletext-related struct members of tv_param_t in stream/tv.h to
a new struct tt_param_t, defined in libmpcodecs/dec_teletext.h
- Added pointer to demuxer in tvi_handle_t type in stream/tv.h, needed
by stream/tv.c to call teletext_control()
- Added pointer to teletext decoder private data to demuxer_t in
libmpdemux/demuxer.h, needed by command.c and mpcommon.c to call
teletext_control()
- Added MSGT_TELETEXT definition in mp_msg.h, used by teletext decoder
to output debug messages

-------------- next part --------------
A non-text attachment was scrubbed...
Name: teletext.patch
Type: text/x-patch
Size: 31809 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090802/d36f4029/attachment.bin>