[MPlayer-dev-eng] [PATCH] Add DVB teletext support
francescolavra at interfree.it
Sun Aug 2 16:08:15 CEST 2009
On Sun, 2009-08-02 at 13:30 +0200, Diego Biurrun wrote:
> > > Is the #ifdef necessary?
> > It is not really necessary, I just followed the coding style present in
> > that file (see the 30 or so lines above my addition)
> Those #ifdefs should be necessary or else they should be removed.
> > > I think this patch would be smaller if you moved stuff around with 'svn
> > > cp' before creating the diff.
> > I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> > code from tv.h
> You are copying code. Use svn cp.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 80269 bytes
Desc: not available
More information about the MPlayer-dev-eng