[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Diego Biurrun]

On Sun, Aug 02, 2009 at 01:14:12PM +0200, Francesco Lavra wrote:
> On Sun, 2009-08-02 at 10:56 +0200, Diego Biurrun wrote:
> > On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> > > 
> > > --- command.c	(revision 29464)
> > > +++ command.c	(working copy)
> > > @@ -57,6 +57,9 @@
> > >  #ifdef CONFIG_GUI
> > >  #include "gui/interface.h"
> > >  #endif
> > > +#ifdef CONFIG_TV_TELETEXT
> > > +#include "libmpcodecs/dec_teletext.h"
> > > +#endif
> > 
> > Is the #ifdef necessary?
> It is not really necessary, I just followed the coding style present in
> that file (see the 30 or so lines above my addition)

Those #ifdefs should be necessary or else they should be removed.

> > I think this patch would be smaller if you moved stuff around with 'svn
> > cp' before creating the diff.
> I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> code from tv.h

You are copying code.  Use svn cp.

Diego

P.S.: It would greatly help the readability of your emails if you left a
blank line between the quotes and your replies.